Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23346 )
Change subject: IMPALA-14330: set a valid createEventId in global INVALIDATE METADATA ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/23346/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/23346/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@5877 PS3, Line 5877: oldTbl.toInvalidationObject() : oldTbl.toMinimalTCatalogObject(); > My comment was a minor nit about making it part of the > if(result.second==null) else block at line 5909. To be clear, it's not just a refactor. Moving this down to line 5909 means setting the createEventId later, i.e. after the if-block on line 5880-5896 which might take some time to get the TCatalogObject of the old table. We should set createEventId ASAP right after the table object is added into catalog (for RENAME it's added in catalog_.renameTable()). So the table won't be incorrectly dropped by concurrent event processing. > This is a fine "just in case", but if I understand you correctly then this > line should never be hit. Oops, I just realized I forgot to remove this in the latest patch set.. Removed it. -- To view, visit http://gerrit.cloudera.org:8080/23346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6506821dedf7701cdfa58d14cae5760ee178c4ec Gerrit-Change-Number: 23346 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 03 Sep 2025 00:36:11 +0000 Gerrit-HasComments: Yes
