Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23346 )
Change subject: IMPALA-14330: set a valid createEventId in global INVALIDATE METADATA ...................................................................... Patch Set 2: (2 comments) I only have nits. http://gerrit.cloudera.org:8080/#/c/23346/2/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java File fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java: http://gerrit.cloudera.org:8080/#/c/23346/2/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java@195 PS2, Line 195: // Setting 'createEventId_' and 'lastSyncedEventId_' directly instead of calling : // setCreateEventId() to avoid excessive logs for all tables during catalogd startup. : tbl.createEventId_ = createEventId; : tbl.lastSyncedEventId_ = createEventId; nit: Creating an overload of setCreateEventId() that log less/differently might be better. http://gerrit.cloudera.org:8080/#/c/23346/2/tests/custom_cluster/test_concurrent_ddls.py File tests/custom_cluster/test_concurrent_ddls.py: http://gerrit.cloudera.org:8080/#/c/23346/2/tests/custom_cluster/test_concurrent_ddls.py@103 PS2, Line 103: self.client = test_self.create_impala_client() nit: I've seen single ImpylaHS2Connection behave erratically when shared across multiple threads + execute_async. Please check /sessions page when running this test and make sure things look OK. If not, consider having single client per thread within the run method and make sure client are closed in the end, whether test successful or not. -- To view, visit http://gerrit.cloudera.org:8080/23346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6506821dedf7701cdfa58d14cae5760ee178c4ec Gerrit-Change-Number: 23346 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 27 Aug 2025 03:28:32 +0000 Gerrit-HasComments: Yes
