Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23346 )
Change subject: IMPALA-14330: set a valid createEventId in global INVALIDATE METADATA ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23346/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/23346/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@5877 PS3, Line 5877: } > Not removing it, but moving it into the caller and then move it inside Cata This is a fine "just in case", but if I understand you correctly then this line should never be hit. My comment was a minor nit about making it part of the if(result.second==null) else block at line 5909. -- To view, visit http://gerrit.cloudera.org:8080/23346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6506821dedf7701cdfa58d14cae5760ee178c4ec Gerrit-Change-Number: 23346 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 02 Sep 2025 23:30:38 +0000 Gerrit-HasComments: Yes
