Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23113 )
Change subject: IMPALA-13267: Display number of partitions for Iceberg tables ...................................................................... Patch Set 7: (5 comments) Thanks, looks good. http://gerrit.cloudera.org:8080/#/c/23113/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23113/7//COMMIT_MSG@22 PS7, Line 22: the Nit: no need for "the". http://gerrit.cloudera.org:8080/#/c/23113/7//COMMIT_MSG@24 PS7, Line 24: /N/A Nit: maybe NA or "?" would be better since we already have a "/". http://gerrit.cloudera.org:8080/#/c/23113/7/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java File fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java: http://gerrit.cloudera.org:8080/#/c/23113/7/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@409 PS7, Line 409: public static List<TIcebergPartition> convertPartitionMapToList( Now that we have getPartitionList(), this function and convertPartitionListToMap() could be private. http://gerrit.cloudera.org:8080/#/c/23113/7/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/23113/7/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@74 PS7, Line 74: import static org.apache.impala.catalog.IcebergContentFileStore.convertPartitionMapToList; Unused import. http://gerrit.cloudera.org:8080/#/c/23113/7/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/23113/7/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@2086 PS7, Line 2086: table.getPartitions().size() This could be getNumPartitions(), in case it changes in the future. -- To view, visit http://gerrit.cloudera.org:8080/23113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb2f654bc6c9bdf9cfafc27b38b5ca2f7b6b4872 Gerrit-Change-Number: 23113 Gerrit-PatchSet: 7 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 28 Aug 2025 12:11:30 +0000 Gerrit-HasComments: Yes
