Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23113 )
Change subject: IMPALA-13267: Display number of partitions for Iceberg tables ...................................................................... Patch Set 10: (13 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23113/10/common/fbs/IcebergObjects.fbs File common/fbs/IcebergObjects.fbs: PS10: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new fields can be added and should be added at the end of a table definition. https://flatbuffers.dev/flatbuffers_guide_writing_schema.html http://gerrit.cloudera.org:8080/#/c/23113/10/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/23113/10/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@248 PS10, Line 248: Snapshot currentSnapshot = ((FeIcebergTable) table).getIcebergApiTable().currentSnapshot(); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/23113/10/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java File fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java: http://gerrit.cloudera.org:8080/#/c/23113/10/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@263 PS10, Line 263: /* oldFds = */ fml1.getLoadedIcebergFds().subList(0, 10), fml1.getIcebergPartitionList(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/23113/10/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@279 PS10, Line 279: /* oldFds = */ fml2.getLoadedIcebergFds().subList(0, 10), fml1.getIcebergPartitionList(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/23113/10/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@299 PS10, Line 299: /* oldFds = */ fml1.getLoadedIcebergFds().subList(0, 10), fml1.getIcebergPartitionList(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/23113/10/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@307 PS10, Line 307: /* oldFds = */ fml1.getLoadedIcebergFds().subList(0, 10), fml1.getIcebergPartitionList(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/23113/10/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@315 PS10, Line 315: /* oldFds = */ fml1.getLoadedIcebergFds().subList(0, 10), fml1.getIcebergPartitionList(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/23113/10/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@321 PS10, Line 321: /* oldFds = */ fml1.getLoadedIcebergFds().subList(0, 10), fml1.getIcebergPartitionList(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/23113/10/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@335 PS10, Line 335: /* oldFds = */ fml2.getLoadedIcebergFds().subList(0, 10), fml1.getIcebergPartitionList(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/23113/10/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@339 PS10, Line 339: /* oldFds = */ fml2.getLoadedIcebergFds().subList(0, 10), fml1.getIcebergPartitionList(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/23113/10/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@345 PS10, Line 345: /* oldFds = */ fml2.getLoadedIcebergFds().subList(0, 10), fml1.getIcebergPartitionList(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/23113/10/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@363 PS10, Line 363: /* oldFds = */ fml1.getLoadedIcebergFds().subList(0, 1), fml1.getIcebergPartitionList(), line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/23113/10/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@373 PS10, Line 373: /* oldFds = */ fml1.getLoadedIcebergFds().subList(0, 5), fml1.getIcebergPartitionList(), line too long (97 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb2f654bc6c9bdf9cfafc27b38b5ca2f7b6b4872 Gerrit-Change-Number: 23113 Gerrit-PatchSet: 10 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 09 Sep 2025 10:30:16 +0000 Gerrit-HasComments: Yes
