Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23113 )
Change subject: IMPALA-13267: Display number of partitions for Iceberg tables ...................................................................... Patch Set 11: (6 comments) IMPALA-14349 will interfere with this, otherwise no serious issues found. http://gerrit.cloudera.org:8080/#/c/23113/11/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/23113/11/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@904 PS11, Line 904: TODO noemi Do you have a Jira ticket about this? Or do you plan to resolve it in this CR? http://gerrit.cloudera.org:8080/#/c/23113/11/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/23113/11/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@242 PS11, Line 242: containsKey I think we should just use get() and a null-check, to make sure we don't traverse the hash map twice. http://gerrit.cloudera.org:8080/#/c/23113/11/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@291 PS11, Line 291: containsKey(partition) Better to do get() and null-check. http://gerrit.cloudera.org:8080/#/c/23113/11/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@293 PS11, Line 293: { : partitionId = loadedIcebergPartitions_.size(); : loadedIcebergPartitions_.put(partition, partitionId); : } After IMPALA-14349 (which is about to get merged) this should be synchronized, and loadedIcebergPartitions_ should be a ConcurrentHashMap. Sorry :) http://gerrit.cloudera.org:8080/#/c/23113/11/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/23113/11/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@850 PS11, Line 850: containsKey(partition) get() and null-check is more efficient. http://gerrit.cloudera.org:8080/#/c/23113/11/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/23113/11/tests/query_test/test_iceberg.py@2241 PS11, Line 2241: HDFS This will be S3/Ozone on different filesystems -- To view, visit http://gerrit.cloudera.org:8080/23113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb2f654bc6c9bdf9cfafc27b38b5ca2f7b6b4872 Gerrit-Change-Number: 23113 Gerrit-PatchSet: 11 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 09 Sep 2025 13:30:01 +0000 Gerrit-HasComments: Yes
