Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23113 )
Change subject: IMPALA-13267: Display number of partitions for Iceberg tables (WIP) ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/23113/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23113/4//COMMIT_MSG@11 PS4, Line 11: for users. : Now we can display the number of scanned partitions correctly for > This is the current implementation, but might be a bit misleading in case o If we don't know the number of partitions at that stage, I think it would be better to omit info about the number of partitions currently, so we should only display the number of partitions read (and add NA or some placeholder for the total value). http://gerrit.cloudera.org:8080/#/c/23113/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/23113/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@833 PS5, Line 833: Nit: extra indentation on these lines. -- To view, visit http://gerrit.cloudera.org:8080/23113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb2f654bc6c9bdf9cfafc27b38b5ca2f7b6b4872 Gerrit-Change-Number: 23113 Gerrit-PatchSet: 5 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Fri, 08 Aug 2025 12:56:05 +0000 Gerrit-HasComments: Yes
