Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22870 )
Change subject: IMPALA-14061: Calcite Planner: added Calcite rules ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22870/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/22870/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@102 PS4, Line 102: RelNode preJoinOptimizedPlan = runOptimizeNodesProgram(relBuilder, coercedNodesPlan); > because i upgrade calcite version to 1.39 in my local codebase, and work we Ah, got it. I did experiment with 1.39 and there was another issue which I can't remember right now. But I needed to delay the upgrade...now you've given me something else to be concerned about :) -- To view, visit http://gerrit.cloudera.org:8080/22870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6671f7ed298a18965ef0b7a5fc10f4912333a52b Gerrit-Change-Number: 22870 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Thu, 15 May 2025 02:54:35 +0000 Gerrit-HasComments: Yes
