Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22870 )
Change subject: IMPALA-14061: Calcite Planner: added Calcite rules ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22870/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/22870/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@102 PS4, Line 102: RelNode preJoinOptimizedPlan = runOptimizeNodesProgram(relBuilder, coercedNodesPlan); > create table t1(k1 bigint, k2 bigint); Hmmm...I just tried this with my latest patch and I can't reproduce :( LogicalSort(sort0=[$0], sort1=[$1], dir0=[ASC], dir1=[ASC]), id = 9 LogicalProject(k1=[$0], k2=[$1]), id = 8 LogicalJoin(condition=[AND(=($1, $4), OR(=($0, 1), =($0, 2), =($0, 3), =($0, 5)))], joinType=[left]), id = 5 LogicalTableScan(table=[[sjc_db, t1]]), id = 1 LogicalTableScan(table=[[sjc_db, t2]]), id = 3 I0514 11:32:14.209854 21845 LogUtil.java:43] 02494d7c7e8cd8f1:e3257f6200000000] [After subquery removed] LogicalSort(sort0=[$0], sort1=[$1], dir0=[ASC], dir1=[ASC]), id = 9 LogicalProject(k1=[$0], k2=[$1]), id = 8 LogicalJoin(condition=[AND(=($1, $4), OR(=($0, 1), =($0, 2), =($0, 3), =($0, 5)))], joinType=[left]), id = 5 LogicalTableScan(table=[[sjc_db, t1]]), id = 1 LogicalTableScan(table=[[sjc_db, t2]]), id = 3 I0514 11:32:14.220149 21845 LogUtil.java:43] 02494d7c7e8cd8f1:e3257f6200000000] [After decorrelation] LogicalSort(sort0=[$0], sort1=[$1], dir0=[ASC], dir1=[ASC]), id = 9 LogicalProject(k1=[$0], k2=[$1]), id = 8 LogicalJoin(condition=[AND(=($1, $4), OR(=($0, 1), =($0, 2), =($0, 3), =($0, 5)))], joinType=[left]), id = 5 LogicalTableScan(table=[[sjc_db, t1]]), id = 1 LogicalTableScan(table=[[sjc_db, t2]]), id = 3 I0514 11:32:14.249599 21845 LogUtil.java:43] 02494d7c7e8cd8f1:e3257f6200000000] [expand nodes] LogicalSort(sort0=[$0], sort1=[$1], dir0=[ASC], dir1=[ASC]), id = 24 LogicalProject(k1=[$0], k2=[$1]), id = 22 LogicalJoin(condition=[AND(=($1, $4), OR(=($0, 1), =($0, 2), =($0, 3), =($0, 5)))], joinType=[left]), id = 20 LogicalTableScan(table=[[sjc_db, t1]]), id = 1 LogicalTableScan(table=[[sjc_db, t2]]), id = 3 I0514 11:32:14.256036 21845 LogUtil.java:43] 02494d7c7e8cd8f1:e3257f6200000000] [coerce nodes] LogicalSort(sort0=[$0], sort1=[$1], dir0=[ASC], dir1=[ASC]), id = 28 LogicalProject(k1=[$0], k2=[$1]), id = 27 LogicalJoin(condition=[AND(=($1, $4), OR(=($0, 1), =($0, 2), =($0, 3), =($0, 5)))], joinType=[left]), id = 26 LogicalTableScan(table=[[sjc_db, t1]]), id = 1 LogicalTableScan(table=[[sjc_db, t2]]), id = 3 I0514 11:32:14.318707 21845 LogUtil.java:43] 02494d7c7e8cd8f1:e3257f6200000000] [optimize pre join] LogicalSort(sort0=[$0], sort1=[$1], dir0=[ASC], dir1=[ASC]), id = 39 LogicalProject(k1=[$0], k2=[$1]), id = 49 LogicalJoin(condition=[AND(=($1, $3), $2)], joinType=[left]), id = 47 LogicalProject(k1=[$0], k2=[$1], EXPR$0=[OR(=($0, 1), =($0, 2), =($0, 3), =($0, 5))]), id = 41 LogicalTableScan(table=[[sjc_db, t1]]), id = 1 LogicalProject(k3=[$2]), id = 42 LogicalTableScan(table=[[sjc_db, t2]]), id = 3 Questions: 1) Are you on my latest patch? 2) If SEARCH is in there, did you see the query fail? Or was there some correction later on that fixed it? -- To view, visit http://gerrit.cloudera.org:8080/22870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6671f7ed298a18965ef0b7a5fc10f4912333a52b Gerrit-Change-Number: 22870 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Wed, 14 May 2025 18:38:21 +0000 Gerrit-HasComments: Yes
