Anonymous Coward (816) has posted comments on this change. ( http://gerrit.cloudera.org:8080/22870 )
Change subject: IMPALA-14061: (WIP) draft ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22870/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/22870/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@275 PS3, Line 275: public String getDebugString(Object optimizedPlan, String planString) { : return RelOptUtil.dumpPlan("[" + planString + "]", (RelNode) optimizedPlan, : SqlExplainFormat.TEXT, SqlExplainLevel.NON_COST_ATTRIBUTES); : } : : @Override : public void logDebug(Object resultObject) { : logDebug(resultObject, "Optimized Plan"); : } : : public void logDebug(Object resultObject, String planString) { : if (!(resultObject instanceof RelNode)) { : LOG.debug("Finished optimizer step, but unknown result: " + resultObject); : return; : } : LOG.info(getDebugString(resultObject, planString)); : } in CalciteRelNodeConverter.java have 3 steps: 1. Convert the valid AST into a logical plan 2. SubQuery Remove 3. Decorrelate Query maybe can reuse public void logDebug(Object resultObject, String planString) {} to show each step's changes. -- To view, visit http://gerrit.cloudera.org:8080/22870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6671f7ed298a18965ef0b7a5fc10f4912333a52b Gerrit-Change-Number: 22870 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Sun, 11 May 2025 09:48:31 +0000 Gerrit-HasComments: Yes
