Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22870 )
Change subject: IMPALA-14061: Calcite Planner: added Calcite rules ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22870/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/22870/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@102 PS4, Line 102: RelNode preJoinOptimizedPlan = runOptimizeNodesProgram(relBuilder, coercedNodesPlan); > sorry to bother you. Oh, ha! No bother at all! It's actually really good that someone is interested in this! I meant to reply yesterday though and didn't. I'm wondering...is it a good idea to keep up with the latest? The reason I ask is specifically because of the problem you hit: 1.37 works fine, but 1.39 does not. So if we were to always use the latest version, we're gonna hit a situation where: The upgrade from 1.39 to 1.40 happens on a Tuesday that breaks something. Someone goes to push something on Jenkins on a Tuesday and it works fine. On Wednesday it does not. Then theyll be scrambling to figure out what happened, only to find out that it was completely unrelated to their commit. I do like the idea of keeping up with the latest, of course. I wish I could think of a middle ground. But regardless, I'm stuck on 1.37 because 1.38 breaks stuff. 1.38 also fixes stuff too: there's a decimal overflow problem that goes away. But yeah...if you have a different take on this, let me know. -- To view, visit http://gerrit.cloudera.org:8080/22870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6671f7ed298a18965ef0b7a5fc10f4912333a52b Gerrit-Change-Number: 22870 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Fri, 16 May 2025 16:22:28 +0000 Gerrit-HasComments: Yes
