Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/22662 )
Change subject: IMPALA-3841: Enable late materialization for collections ...................................................................... Patch Set 9: (2 comments) > Patch Set 8: > > (2 comments) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/22662/8/be/src/exec/parquet/parquet-column-readers.cc File be/src/exec/parquet/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/22662/8/be/src/exec/parquet/parquet-column-readers.cc@1348 PS8, Line 1348: t64_t num_rows_to_skip = num_rows; > SkipTopLevelRows() is used in other contexts also, not just with late mater Thanks! Changed the name of the counter. http://gerrit.cloudera.org:8080/#/c/22662/8/be/src/exec/parquet/parquet-column-readers.cc@1348 PS8, Line 1348: > Isn't it just rows_skipped? Thanks! Changed. -- To view, visit http://gerrit.cloudera.org:8080/22662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21bdfa6811408d66d74367e0a9520e20951105f Gerrit-Change-Number: 22662 Gerrit-PatchSet: 9 Gerrit-Owner: Xuebin Su <x...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Xuebin Su <x...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 08 May 2025 10:20:21 +0000 Gerrit-HasComments: Yes
