Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22662 )
Change subject: IMPALA-3841: Enable late materialization for collections ...................................................................... Patch Set 10: Code-Review+1 (1 comment) Left one note about the name of the new counter. Otherwise I'm ready to +2 it. http://gerrit.cloudera.org:8080/#/c/22662/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22662/10//COMMIT_MSG@38 PS10, Line 38: NumRowsSkipped Since it is counted per column, maybe the name NumValuesSkipped would be more precise. Otherwise it could be confusing if "NumRowsSkipped" is higher than the number of rows in the table. -- To view, visit http://gerrit.cloudera.org:8080/22662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21bdfa6811408d66d74367e0a9520e20951105f Gerrit-Change-Number: 22662 Gerrit-PatchSet: 10 Gerrit-Owner: Xuebin Su <x...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Xuebin Su <x...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 16 May 2025 15:52:02 +0000 Gerrit-HasComments: Yes
