Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/22662 )
Change subject: IMPALA-3841: Enable late materialization for collections ...................................................................... Patch Set 7: (2 comments) > Patch Set 5: > > (3 comments) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/22662/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22662/2//COMMIT_MSG@9 PS2, Line 9: enables > I lean towards setting it to 1 if there is any collection column whose mate Thanks! Changed and added test cases. http://gerrit.cloudera.org:8080/#/c/22662/5/be/src/exec/parquet/parquet-column-readers.cc File be/src/exec/parquet/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/22662/5/be/src/exec/parquet/parquet-column-readers.cc@1530 PS5, Line 1530: DCHECK_LT(num_values_read_, metadata_->num_values); > Shouldn't num_rows_skipped_by_late_materialization_counter_ be nulled here? Thanks! Fixed and added test cases. -- To view, visit http://gerrit.cloudera.org:8080/22662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21bdfa6811408d66d74367e0a9520e20951105f Gerrit-Change-Number: 22662 Gerrit-PatchSet: 7 Gerrit-Owner: Xuebin Su <x...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Xuebin Su <x...@cloudera.com> Gerrit-Comment-Date: Tue, 29 Apr 2025 08:26:59 +0000 Gerrit-HasComments: Yes
