Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22662 )
Change subject: IMPALA-3841: Enable late materialization for collections ...................................................................... Patch Set 7: (3 comments) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/22662/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22662/7//COMMIT_MSG@26 PS7, Line 26: I know you already have some measurements, could you please add a few numbers, like * how does it improve perf when there are collections * does it affect scanning Parquet files without collections http://gerrit.cloudera.org:8080/#/c/22662/7/be/src/exec/parquet/parquet-collection-column-reader.cc File be/src/exec/parquet/parquet-collection-column-reader.cc: http://gerrit.cloudera.org:8080/#/c/22662/7/be/src/exec/parquet/parquet-collection-column-reader.cc@181 PS7, Line 181: CollectionColumnReader:: nit: do we need to qualify this here? http://gerrit.cloudera.org:8080/#/c/22662/7/be/src/exec/parquet/parquet-column-readers.cc File be/src/exec/parquet/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/22662/7/be/src/exec/parquet/parquet-column-readers.cc@1347 PS7, Line 1347: num_rows_skipped_by_late_materialization_counter_ += (num_rows_to_skip - *remaining); Could you please add a comment why we increase the counter here? -- To view, visit http://gerrit.cloudera.org:8080/22662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21bdfa6811408d66d74367e0a9520e20951105f Gerrit-Change-Number: 22662 Gerrit-PatchSet: 7 Gerrit-Owner: Xuebin Su <x...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Xuebin Su <x...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 30 Apr 2025 17:19:56 +0000 Gerrit-HasComments: Yes
