Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/22853 )
Change subject: IMPALA-14028: Refactor cancel_query_and_validate_state with HS2 ...................................................................... Patch Set 3: (2 comments) Hi! http://gerrit.cloudera.org:8080/#/c/22853/3/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/22853/3/be/src/service/impala-hs2-server.cc@879 PS3, Line 879: bool ImpalaServer::HandleOperationStatusIfError(TGetOperationStatusResp& return_val, Can we call HS2_RETURN_ERROR() in this function to make this function easier to read? http://gerrit.cloudera.org:8080/#/c/22853/3/tests/util/cancel_util.py File tests/util/cancel_util.py: http://gerrit.cloudera.org:8080/#/c/22853/3/tests/util/cancel_util.py@222 PS3, Line 222: thread.cancel_query() I think the cancel operation is executed in the main thread instead of in another thread. Is that correct? -- To view, visit http://gerrit.cloudera.org:8080/22853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I626a1a06eb3d5dc9737c7d4289720e1f52d2a984 Gerrit-Change-Number: 22853 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Xuebin Su <x...@cloudera.com> Gerrit-Comment-Date: Tue, 06 May 2025 03:32:21 +0000 Gerrit-HasComments: Yes
