Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22853 )
Change subject: IMPALA-14028: Refactor cancel_query_and_validate_state with Impyla ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22853/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22853/1//COMMIT_MSG@20 PS1, Line 20: 2. Make client operation such as execute_async, fetch, cancel, : get_runtime_profile mutually exclusive. : 3. Do not attempt to fetch if there is a debug action set to prevent it : (ie., wait GetNext indefinitely). I don't understand the tests completely, but isn't it actually goal to test these cases, for example killing a query while there is a parallel fetch? This should be possible if the cancellation/kill happens on a different connection. This is possible with MinimalHS2Connection. http://gerrit.cloudera.org:8080/#/c/22853/1/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/22853/1/be/src/service/impala-hs2-server.cc@96 PS1, Line 96: #define HS2_OPERATION_RETURN_IF_ERROR(return_val, status, error_state) \ Does this really have to be a macro? An alternative would be a function like bool HandleIfError(...) and have if (HandleIfError(...)) return; blocks at the call sites. http://gerrit.cloudera.org:8080/#/c/22853/1/tests/util/cancel_util.py File tests/util/cancel_util.py: http://gerrit.cloudera.org:8080/#/c/22853/1/tests/util/cancel_util.py@151 PS1, Line 151: string_buffer = io.StringIO() : traceback.print_exc(file=string_buffer) : stack_trace_string = string_buffer.getvalue() Doesn't traceback.format_exc() do the same? -- To view, visit http://gerrit.cloudera.org:8080/22853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I626a1a06eb3d5dc9737c7d4289720e1f52d2a984 Gerrit-Change-Number: 22853 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Xuebin Su <x...@cloudera.com> Gerrit-Comment-Date: Mon, 05 May 2025 12:54:27 +0000 Gerrit-HasComments: Yes
