Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22853 )

Change subject: IMPALA-14028: Refactor cancel_query_and_validate_state with HS2
......................................................................


Patch Set 2:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22853/2/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:

http://gerrit.cloudera.org:8080/#/c/22853/2/be/src/service/impala-hs2-server.cc@880
PS2, Line 880:     TGetOperationStatusResp& return_val, const Status& status, 
const string& error_state) {
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I626a1a06eb3d5dc9737c7d4289720e1f52d2a984
Gerrit-Change-Number: 22853
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Xuebin Su <x...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 01:19:01 +0000
Gerrit-HasComments: Yes

Reply via email to