Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22853 )
Change subject: IMPALA-14028: Refactor cancel_query_and_validate_state with HS2 ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/22853/4/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/22853/4/be/src/service/impala-hs2-server.cc@901 PS4, Line 901: // Make query id available to the following HS2_RETURN_ERROR(). > It seems that we also need to update this comment. Done http://gerrit.cloudera.org:8080/#/c/22853/4/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22853/4/tests/common/impala_connection.py@1132 PS4, Line 1132: : def get_log(self, operation_handle): : return self.__get_operation(operation_handle).get_log() : : def set_configuration_option(self, name, value, is_log_sql=True): : # Only set the option if it's not already set to the same value. : # value must be parsed to string. : name = name.lower() : value = str(value) : if self.__query_options.get(name, "") != value: : self.__query_options[name] = value : if is_log_ > This will require some adjustment to follow https://gerrit.cloudera.org/c/2 Done -- To view, visit http://gerrit.cloudera.org:8080/22853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I626a1a06eb3d5dc9737c7d4289720e1f52d2a984 Gerrit-Change-Number: 22853 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Xuebin Su <x...@cloudera.com> Gerrit-Comment-Date: Fri, 09 May 2025 09:18:32 +0000 Gerrit-HasComments: Yes
