Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/22734 )
Change subject: IMPALA-10268: Validate the debug actions when they are set ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22734/4/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/22734/4/be/src/service/query-options.cc@319 PS4, Line 319: "invalid command" > I see. You are right. Yes all errors should be propagated, except this one special case: https://github.com/mszjat/impala/blob/test_debugaction_wrapper/be/src/util/debug-util.cc#L462 Because this can be from trying interpreting ExecNode debug action, so in this case we give it a try with further 'VerifyDebugAction()' -- To view, visit http://gerrit.cloudera.org:8080/22734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53816aba2c79b556688d3b916883fee7476fdbb5 Gerrit-Change-Number: 22734 Gerrit-PatchSet: 4 Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 10:05:01 +0000 Gerrit-HasComments: Yes
