Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22734 )
Change subject: IMPALA-10268: Validate the debug actions when they are set ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/22734/3/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: http://gerrit.cloudera.org:8080/#/c/22734/3/be/src/exec/exec-node.cc@466 PS3, Line 466: RETURN_IF_ERROR( : ParseAndValidateSleepDuration(debug_options_.action_param, &sleep_duration_ms)); : VLOG(1) << "DEBUG_ACTION: Sleeping for " << sleep_duration_ms << "ms"; : S > I moved 'VerifyDebugAction()' to query-options.h as proposed in another th Done http://gerrit.cloudera.org:8080/#/c/22734/3/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/22734/3/be/src/service/query-options.cc@307 PS3, Line 307: break; : } : case TImpalaQueryOptions::NUM_SCANNER_THREADS: { : i > 'value' string may contain both General and ExecNode debug actions. 'DebugA Done http://gerrit.cloudera.org:8080/#/c/22734/3/be/src/service/query-options.cc@307 PS3, Line 307: break; : } : case TImpalaQueryOptions::NUM_SCANNER_THREADS: { : int32_t int32_t_val = 0; : RETURN_IF_ERROR(QueryOptionParser::Parse<int32_t>(option, value, &int32_t_val)); : query_options->__set_num_scanner_threads(int32_t_val); > Done Done http://gerrit.cloudera.org:8080/#/c/22734/4/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/22734/4/be/src/service/query-options.cc@319 PS4, Line 319: "invalid command" Consider making this a constant string and use it both here and in DebugActionImpl. http://gerrit.cloudera.org:8080/#/c/22734/3/be/src/util/debug-util.h File be/src/util/debug-util.h: http://gerrit.cloudera.org:8080/#/c/22734/3/be/src/util/debug-util.h@147 PS3, Line 147: /// Slow path implementing DebugAction() for the case where 'debug_action' is non-empty. > Ack Done -- To view, visit http://gerrit.cloudera.org:8080/22734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53816aba2c79b556688d3b916883fee7476fdbb5 Gerrit-Change-Number: 22734 Gerrit-PatchSet: 4 Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 16 Apr 2025 14:12:22 +0000 Gerrit-HasComments: Yes
