Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22734 )
Change subject: IMPALA-10268: Validate the debug actions when they are set ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22734/4/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/22734/4/be/src/service/query-options.cc@319 PS4, Line 319: "invalid command" > I got that, in DebugActionImpl() there's already a constant string ERROR_MS I see. You are right. But in that case, isn't it safe to return all non-OK status from DebugActionVerifyOnly()? RETURN_IF_ERROR(DebugActionVerifyOnly(value)); If verification pass, then there should be no non-OK status returned. The only non-OK status that is not using ERROR_MSG template is Status(TErrorCode::INTERNAL_ERROR, error_msg), and it is only possible to throw if verify_only is False. -- To view, visit http://gerrit.cloudera.org:8080/22734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53816aba2c79b556688d3b916883fee7476fdbb5 Gerrit-Change-Number: 22734 Gerrit-PatchSet: 4 Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 16 Apr 2025 19:34:29 +0000 Gerrit-HasComments: Yes
