Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22734 )
Change subject: IMPALA-10268: Validate the debug actions when they are set ...................................................................... Patch Set 6: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22734/6/tests/query_test/test_debug_action.py File tests/query_test/test_debug_action.py: http://gerrit.cloudera.org:8080/#/c/22734/6/tests/query_test/test_debug_action.py@84 PS6, Line 84: @classmethod : def get_workload(cls): : return 'functional-query' nit: This can be removed. http://gerrit.cloudera.org:8080/#/c/22734/6/tests/query_test/test_debug_action.py@95 PS6, Line 95: # Debug actions should be independent of file format, so only testing for : # table_format=parquet/none in order to avoid a test dimension explosion. : cls.ImpalaTestMatrix.add_constraint(lambda v: : v.get_value('table_format').file_format == 'parquet' : and v.get_value('table_format').compression_codec == 'none') You can replace this with a fixed table_format dimension. cls.ImpalaTestMatrix.add_dimension(create_parquet_dimension()) -- To view, visit http://gerrit.cloudera.org:8080/22734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53816aba2c79b556688d3b916883fee7476fdbb5 Gerrit-Change-Number: 22734 Gerrit-PatchSet: 6 Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 22 Apr 2025 15:05:48 +0000 Gerrit-HasComments: Yes
