Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22653 )
Change subject: IMPALA-13884: Add more details in metadata loading logs ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/22653/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22653/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@636 PS6, Line 636: Throwable > Is it better to use CatalogException with descriptive message here? I think using Throwable is more common. CatalogException looks more like a real exception. https://stackoverflow.com/questions/1069066/how-can-i-get-the-current-stack-trace-in-java Added some description. http://gerrit.cloudera.org:8080/#/c/22653/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/22653/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@818 PS6, Line 818: ":" > How about separator other than whitespace? colon maybe? Yeah, that's better and is consistent with the catalog object key: https://github.com/apache/impala/blob/b410a90b4707be2e08dcb6c02b9473aa9ade8d96/fe/src/main/java/org/apache/impala/catalog/Catalog.java#L710-L712 http://gerrit.cloudera.org:8080/#/c/22653/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2875 PS6, Line 2875: rom the b > Can batch == 0 ? Good catch! Use batchedEvents_ instead and override getEventDesc() using these. -- To view, visit http://gerrit.cloudera.org:8080/22653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I204d5922e055fd8501b5573e3b913f8874d891d6 Gerrit-Change-Number: 22653 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 26 Mar 2025 12:19:50 +0000 Gerrit-HasComments: Yes
