Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22653 )
Change subject: IMPALA-13884: Add more details in metadata loading logs ...................................................................... Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/22653/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22653/5//COMMIT_MSG@27 PS5, Line 27: AlterType. E.g. : execDdl req > It's done in CatalogServiceCatalog.tryLock(): Done http://gerrit.cloudera.org:8080/#/c/22653/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22653/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2644 PS5, Line 2644: LOG.info("Not updating table {} (transactional). Current catalog version: {}." + : " Expected catalog version: {}. Acid compare: {}. Last synced id: {}" > Done. Use "transactional" instead of "Hive-ACID" since it can be an insert- Done http://gerrit.cloudera.org:8080/#/c/22653/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22653/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@636 PS6, Line 636: Throwable Is it better to use CatalogException with descriptive message here? Just to clarify that this is not a real exception happening. http://gerrit.cloudera.org:8080/#/c/22653/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/22653/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@811 PS5, Line 811: Object[] formatArgs = new Object[args.length + 3]; : formatAr > We already log partition values in other places, e.g. Ack http://gerrit.cloudera.org:8080/#/c/22653/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@3360 PS5, Line 3360: > Good point. A method is better. Done http://gerrit.cloudera.org:8080/#/c/22653/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/22653/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@818 PS6, Line 818: " " How about separator other than whitespace? colon maybe? http://gerrit.cloudera.org:8080/#/c/22653/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2875 PS6, Line 2875: batch - 1 Can batch == 0 ? -- To view, visit http://gerrit.cloudera.org:8080/22653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I204d5922e055fd8501b5573e3b913f8874d891d6 Gerrit-Change-Number: 22653 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 26 Mar 2025 00:59:01 +0000 Gerrit-HasComments: Yes
