Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22653 )
Change subject: IMPALA-13884: Add more details in metadata loading logs ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/22653/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22653/5//COMMIT_MSG@27 PS5, Line 27: For the warning of waiting for table write lock too long, also logs the : stacktrace. Where is this stacktrace printing? http://gerrit.cloudera.org:8080/#/c/22653/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22653/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2644 PS5, Line 2644: LOG.info("Not updating transactional table {}. Current catalog version: {}. " + : "Expected catalog version: {}. Acid compare: {}. Last synced id: {}", Can I propose this pattern instead the prefix match with L2635 and L2627 LOG.info("Not updating table {} (Hive-ACID). Current catalog version: {}. " + "Expected catalog version: {}. ACID compare: {}. Last synced id: {}", http://gerrit.cloudera.org:8080/#/c/22653/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/22653/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@811 PS5, Line 811: // AlterPartitionEvent is on a single partition so we can also log the partition : // name. Is it possible to leak sensitive information by printing partition value here? http://gerrit.cloudera.org:8080/#/c/22653/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@3360 PS5, Line 3360: "COMMIT_COMPACTION_EVENT " + getEventId() Can we standardize this pattern into a method returning String? Why not "COMMIT_COMPACTION event " + getEventId() Aren't some of them have static field like this? public static final String EVENT_TYPE = "CREATE_TABLE"; http://gerrit.cloudera.org:8080/#/c/22653/5/fe/src/main/java/org/apache/impala/util/CatalogOpUtil.java File fe/src/main/java/org/apache/impala/util/CatalogOpUtil.java: http://gerrit.cloudera.org:8080/#/c/22653/5/fe/src/main/java/org/apache/impala/util/CatalogOpUtil.java@43 PS5, Line 43: req.getAlter_table_params() nit: Can contain this into a variable first to shorten code. -- To view, visit http://gerrit.cloudera.org:8080/22653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I204d5922e055fd8501b5573e3b913f8874d891d6 Gerrit-Change-Number: 22653 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Mar 2025 21:07:08 +0000 Gerrit-HasComments: Yes
