Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22653 )
Change subject: IMPALA-13884: Add more details in metadata loading logs ...................................................................... Patch Set 9: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/22653/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22653/5//COMMIT_MSG@7 PS5, Line 7: IMPALA-13884: Add more details in metadata loading logs > I think we don't guarantee logs are in the same format between upgrades. Th Ack http://gerrit.cloudera.org:8080/#/c/22653/5//COMMIT_MSG@9 PS5, Line 9: Adds the target of the event in HMS event processing logs. For > The HMS notification events are generated by HMS so they don't have Impala Ah, I misunderstood where the HMS events were coming from. I was thinking it worked the other way (HMS events triggered by Impala operations). http://gerrit.cloudera.org:8080/#/c/22653/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22653/7/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@636 PS7, Line 636: // Skip the first method which is always java.lang.Thread.getStackTrace(). > Done. Ideally we should just log the reason/goal to acquire the lock simila Done http://gerrit.cloudera.org:8080/#/c/22653/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22653/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6374 PS7, Line 6374: String annotation = String.format("Recovering %d partitions for %s", > String.format() still uses different kinds of place holder for different da Ack http://gerrit.cloudera.org:8080/#/c/22653/7/fe/src/main/java/org/apache/impala/util/AcidUtils.java File fe/src/main/java/org/apache/impala/util/AcidUtils.java: http://gerrit.cloudera.org:8080/#/c/22653/7/fe/src/main/java/org/apache/impala/util/AcidUtils.java@137 PS7, Line 137: public static boolean isTransactionalTable(Map<String, String> props) { > It's still used in some places where we don't have the FeTable object, e.g. Ack -- To view, visit http://gerrit.cloudera.org:8080/22653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I204d5922e055fd8501b5573e3b913f8874d891d6 Gerrit-Change-Number: 22653 Gerrit-PatchSet: 9 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Thu, 27 Mar 2025 20:54:23 +0000 Gerrit-HasComments: Yes
