Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22653 )
Change subject: IMPALA-13884: Improve catalogd logs ...................................................................... Patch Set 1: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22653/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/22653/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@583 PS1, Line 583: private static final String STR_FORMAT_EVENT_ID_TYPE = "EventId: %d EventType: %s Target: %s "; line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/22653/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@586 PS1, Line 586: private static final String LOG_FORMAT_EVENT_ID_TYPE = "EventId: {} EventType: {} Target: {} "; line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/22653/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1696 PS1, Line 1696: boolean notSkipped = reloadTableFromCatalog("INSERT event " + getEventId(), false); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I204d5922e055fd8501b5573e3b913f8874d891d6 Gerrit-Change-Number: 22653 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 21 Mar 2025 13:10:48 +0000 Gerrit-HasComments: Yes
