Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22501 )
Change subject: IMPALA-13268: Integrate Iceberg ScanMetrics into Impala query profiles ...................................................................... Patch Set 6: Code-Review+1 (2 comments) LGTM! http://gerrit.cloudera.org:8080/#/c/22501/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22501/6//COMMIT_MSG@9 PS6, Line 9: on Iceberg in Iceberg / on an Iceberg table? http://gerrit.cloudera.org:8080/#/c/22501/6/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/22501/6/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@188 PS6, Line 188: org.apache.impala.service.Frontend Any reason why we fully qualify Frontend? -- To view, visit http://gerrit.cloudera.org:8080/22501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I080ee8eafc459dad4d21356ac9042b72d0570219 Gerrit-Change-Number: 22501 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 14 Mar 2025 16:51:00 +0000 Gerrit-HasComments: Yes
