Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22501 )
Change subject: IMPALA-13268: Integrate Iceberg ScanMetrics into Impala query profiles ...................................................................... Patch Set 6: (3 comments) Thanks Gabor for the review. http://gerrit.cloudera.org:8080/#/c/22501/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/22501/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@101 PS5, Line 101: private static class InMemoryMetricsReporter implements MetricsReporter { > Could you please add a TODO here mentioning the first Iceberg release that Done http://gerrit.cloudera.org:8080/#/c/22501/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@199 PS5, Line 199: } > I see this is because of a previous comment, but I don't see why we need th Done http://gerrit.cloudera.org:8080/#/c/22501/5/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/22501/5/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@1661 PS5, Line 1661: > nit: I find it more readable if we put whatever comes after stream() into a Done -- To view, visit http://gerrit.cloudera.org:8080/22501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I080ee8eafc459dad4d21356ac9042b72d0570219 Gerrit-Change-Number: 22501 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 03 Mar 2025 10:15:15 +0000 Gerrit-HasComments: Yes
