Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22501 )
Change subject: IMPALA-13268: Integrate Iceberg ScanMetrics into Impala query profiles ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/22501/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22501/7//COMMIT_MSG@9 PS7, Line 9: on an Iceberg > nit: on an Iceberg table? Done http://gerrit.cloudera.org:8080/#/c/22501/7/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/22501/7/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@639 PS7, Line 639: } : > Maybe the following is more precise: The intention here was to indicate that 'metricsReporter_' is filled when the try-with-resources block ends, not when the call to IcebergUtil.planFiles() returns. I made the comment clearer and moved it before the try-with-resources block. -- To view, visit http://gerrit.cloudera.org:8080/22501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I080ee8eafc459dad4d21356ac9042b72d0570219 Gerrit-Change-Number: 22501 Gerrit-PatchSet: 9 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 19 Mar 2025 09:00:24 +0000 Gerrit-HasComments: Yes
