Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22501 )
Change subject: IMPALA-13268: Integrate Iceberg ScanMetrics into Impala query profiles ...................................................................... Patch Set 5: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22501/5/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/22501/5/fe/src/main/java/org/apache/impala/service/Frontend.java@2626 PS5, Line 2626: addInfoString(profile, ScanMetrics.TOTAL_DELETE_FILE_SIZE_IN_BYTES, totalDeleteFileSize); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/22501/5/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/22501/5/tests/query_test/test_iceberg.py@1520 PS5, Line 1520: n flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/22501/5/tests/query_test/test_iceberg.py@1521 PS5, Line 1521: } flake8: E123 closing bracket does not match indentation of opening bracket's line http://gerrit.cloudera.org:8080/#/c/22501/5/tests/query_test/test_iceberg.py@1521 PS5, Line 1521: ; flake8: E703 statement ends with a semicolon -- To view, visit http://gerrit.cloudera.org:8080/22501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I080ee8eafc459dad4d21356ac9042b72d0570219 Gerrit-Change-Number: 22501 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 27 Feb 2025 12:25:35 +0000 Gerrit-HasComments: Yes
