Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22591 )
Change subject: IMPALA-13841: Refactor AnalysisResult to make it immutable and simpler ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/22591/7/fe/src/main/java/org/apache/impala/analysis/AnalysisDriver.java File fe/src/main/java/org/apache/impala/analysis/AnalysisDriver.java: http://gerrit.cloudera.org:8080/#/c/22591/7/fe/src/main/java/org/apache/impala/analysis/AnalysisDriver.java@22 PS7, Line 22: /** : * Interface for the analyze method which returns an AnalysisResult. : */ > So my default thinking all along (as shown with my first commit) is to leav I think that make sense to me. You meant something like this, right? public interface AnalysisDriver { /** * Do the statement analysis. * May throws AnalysisException. */ public AnalysisResult analyze() throws AnalysisException; /** * Get the latest (probably mutated) statement. */ public StatementBase getStmt(); /** * Get the latest (probably mutated) analyzer. */ public Analyzer getAnalyzer(); } -- To view, visit http://gerrit.cloudera.org:8080/22591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaf8854b1ce18c72a49893fc36e2cea77b7a2485 Gerrit-Change-Number: 22591 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Mon, 10 Mar 2025 20:29:05 +0000 Gerrit-HasComments: Yes
