Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22591 )
Change subject: IMPALA-13841: Refactor AnalysisResult to make it immutable and simpler ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/22591/5/fe/src/main/java/org/apache/impala/analysis/AnalysisDriver.java File fe/src/main/java/org/apache/impala/analysis/AnalysisDriver.java: http://gerrit.cloudera.org:8080/#/c/22591/5/fe/src/main/java/org/apache/impala/analysis/AnalysisDriver.java@25 PS5, Line 25: public interface AnalysisDriver Just in case we need to release Impala 4.5.1 to fix planner bug, is this easily backported over Impala 4.5.0? http://gerrit.cloudera.org:8080/#/c/22591/5/fe/src/main/java/org/apache/impala/analysis/AnalysisDriver.java@28 PS5, Line 28: public StatementBase getStmt(); : : public Analyzer getAnalyzer(); What is the expectation of return value of each method here? Are the mutable or not? Will they be used for other purpose? Why not accessing the final property inside AnalysisResult? -- To view, visit http://gerrit.cloudera.org:8080/22591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaf8854b1ce18c72a49893fc36e2cea77b7a2485 Gerrit-Change-Number: 22591 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Sat, 08 Mar 2025 01:15:48 +0000 Gerrit-HasComments: Yes
