Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22591 )
Change subject: IMPALA-13841: Refactor AnalysisResult to make it immutable and simpler ...................................................................... Patch Set 10: (12 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22591/10/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/22591/10/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@558 PS10, Line 558: // Enforce the statement expression limit at the end of analysis so that there is an line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22591/10/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@559 PS10, Line 559: // accurate count of the total number of expressions. The first analyze() call is not line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/22591/10/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@560 PS10, Line 560: // very expensive (~seconds) even for large statements. The limit on the total length line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/22591/10/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@562 PS10, Line 562: // It is important to enforce this before expression rewrites, because rewrites are line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22591/10/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@563 PS10, Line 563: // expensive with large expression trees. For example, a SQL that takes a few seconds line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/22591/10/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@567 PS10, Line 567: // The rewrites should have no user-visible effect on query results, including types line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22591/10/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@568 PS10, Line 568: // and labels. Remember the original result types and column labels to restore them line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22591/10/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@569 PS10, Line 569: // after the rewritten stmt has been reset() and re-analyzed. For a CTAS statement, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22591/10/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@570 PS10, Line 570: // the types represent column types of the table that will be created, including the line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22591/10/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@587 PS10, Line 587: // To be consistent with Hive, privilege requests introduced by the masking views line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/22591/10/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@620 PS10, Line 620: // For SetOperationStmt we must replace the query statement with the rewritten version line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22591/10/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@748 PS10, Line 748: new Analyzer(stmtTableCache, ctx.getQueryCtx(), ctx.getAuthzFactory(), authzCtx); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaf8854b1ce18c72a49893fc36e2cea77b7a2485 Gerrit-Change-Number: 22591 Gerrit-PatchSet: 10 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Tue, 11 Mar 2025 10:50:19 +0000 Gerrit-HasComments: Yes
