Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22591 )
Change subject: IMPALA-13841: Refactor AnalysisResult to make it immutable and simpler ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/22591/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22591/8//COMMIT_MSG@12 PS8, Line 12: The AnalysisResult class should be an class with immutable members with : the results obtained from analyzing the query > Mention in commit message that AnalysisResult.userHasProfileAccess_ is stil Done http://gerrit.cloudera.org:8080/#/c/22591/8/fe/src/main/java/org/apache/impala/analysis/AnalysisDriver.java File fe/src/main/java/org/apache/impala/analysis/AnalysisDriver.java: http://gerrit.cloudera.org:8080/#/c/22591/8/fe/src/main/java/org/apache/impala/analysis/AnalysisDriver.java@29 PS8, Line 29: The "analyze" method here does not throw an exception > Please add Preconditions that getException() is null in callsites that assu Done http://gerrit.cloudera.org:8080/#/c/22591/8/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: http://gerrit.cloudera.org:8080/#/c/22591/8/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java@351 PS8, Line 351: return ctx.analyzeAndAuthorize(parsedStmt, stmtTableCache, fe.getAuthzChecker()); > Oh, nevermind. analyzeAndAuthorize() should do the rethrow. Ack -- To view, visit http://gerrit.cloudera.org:8080/22591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaf8854b1ce18c72a49893fc36e2cea77b7a2485 Gerrit-Change-Number: 22591 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Mon, 10 Mar 2025 23:09:27 +0000 Gerrit-HasComments: Yes
