Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22591 )
Change subject: IMPALA-13841: Refactor AnalysisResult to make it immutable and simpler ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/22591/4/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/22591/4/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@95 PS4, Line 95: public AnalysisResult(AnalysisDriver analysisDriver) { > Heh. I was asking myself the same question when I was applying this to the Ack http://gerrit.cloudera.org:8080/#/c/22591/4/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@99 PS4, Line 99: public AnalysisResult(AnalysisDriver analysisDriver, ImpalaException e) { > Yeah, heh. I don't have a strong preference either way. I see how in practice it makes things a little simpler. -- To view, visit http://gerrit.cloudera.org:8080/22591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaf8854b1ce18c72a49893fc36e2cea77b7a2485 Gerrit-Change-Number: 22591 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Sat, 08 Mar 2025 00:59:07 +0000 Gerrit-HasComments: Yes
