Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22591 )
Change subject: IMPALA-13841: Refactor AnalysisResult to make it immutable and simpler ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/22591/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22591/4//COMMIT_MSG@27 PS4, Line 27: with statement types which should be written as a case statement, imo. https://docs.oracle.com/en/java/javase/17/language/pattern-matching-switch.html would be a great fit if we could make Java 17 the minimum version. http://gerrit.cloudera.org:8080/#/c/22591/4/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/22591/4/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@95 PS4, Line 95: public AnalysisResult(AnalysisDriverImpl analysisDriver) { Why wouldn't this take an AnalysisDriver interface instead of the impl? http://gerrit.cloudera.org:8080/#/c/22591/4/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@99 PS4, Line 99: public AnalysisResult(AnalysisDriverImpl analysisDriver, ImpalaException e) { This interface was surprising. Is there some reason it's better than letting analyze() throw an exception? -- To view, visit http://gerrit.cloudera.org:8080/22591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaf8854b1ce18c72a49893fc36e2cea77b7a2485 Gerrit-Change-Number: 22591 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Sat, 08 Mar 2025 00:23:41 +0000 Gerrit-HasComments: Yes
