Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22424 )
Change subject: IMPALA-13675: OAuth AuthN Support for Impala Shell ...................................................................... Patch Set 6: (7 comments) Will the refresh token flow be implemented to automatically refresh expiring access tokens? http://gerrit.cloudera.org:8080/#/c/22424/4/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22424/4/shell/impala_shell.py@1002 PS4, Line 1002: print("Error: OAuth endpoint is empty") > Added payload.encode('utf-8'). Thanks. Done http://gerrit.cloudera.org:8080/#/c/22424/4/shell/impala_shell.py@1003 PS4, Line 1003: sys.exit(1) > No, since we are giving all access to the user. There is no scope associate Ack http://gerrit.cloudera.org:8080/#/c/22424/4/shell/impala_shell.py@1007 PS4, Line 1007: s first usin > Added extra param: oauth_endpoint Done http://gerrit.cloudera.org:8080/#/c/22424/4/shell/impala_shell.py@1008 PS4, Line 1008: try: > Added catch block for HTTPException Does an HTTPException get thrown for error codes other than 100/200/300? http://gerrit.cloudera.org:8080/#/c/22424/6/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22424/6/shell/impala_shell.py@1013 PS6, Line 1013: "application/json Wouldn't hurt to add a charset=utf-8 onto this header value: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Type#syntax http://gerrit.cloudera.org:8080/#/c/22424/6/shell/impala_shell.py@1014 PS6, Line 1014: conn.request("POST", self.oauth_endpoint, payload.encode('utf-8'), headers) Does the '.request' function automatically handle HTTP 301/302 redirects? http://gerrit.cloudera.org:8080/#/c/22424/6/shell/impala_shell.py@1024 PS6, Line 1024: conn.close() What happens here if the 'http.client.HTTPSConnection' function throws an exception? Will conn.close() fail since the connection is not open? -- To view, visit http://gerrit.cloudera.org:8080/22424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84e26d54f6a53696660728efb239ffd43de4c55d Gerrit-Change-Number: 22424 Gerrit-PatchSet: 6 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Thu, 06 Mar 2025 18:12:48 +0000 Gerrit-HasComments: Yes
