Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22424 )
Change subject: IMPALA-13675: OAuth AuthN Support for Impala Shell ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/22424/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22424/4//COMMIT_MSG@13 PS4, Line 13: be prompt to enter Nit: or the user can be prompted to enter http://gerrit.cloudera.org:8080/#/c/22424/4//COMMIT_MSG@15 PS4, Line 15: Change-Id: I84e26d54f6a53696660728efb239ffd43de4c55d Need explanation of what testing was performed. http://gerrit.cloudera.org:8080/#/c/22424/4/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22424/4/shell/impala_shell.py@1002 PS4, Line 1002: conn = http.client.HTTPSConnection(self.oauth_server) Does this connection use UTF-8 encoding by default (since UTF-8 is a requirement for OAuth)? http://gerrit.cloudera.org:8080/#/c/22424/4/shell/impala_shell.py@1003 PS4, Line 1003: payload = "{\"client_id\":\"" + self.user + "\",\"client_secret\":\"" + \ Does this payload also need a "scope" parameter as per https://datatracker.ietf.org/doc/html/rfc6749#section-4.4.2 http://gerrit.cloudera.org:8080/#/c/22424/4/shell/impala_shell.py@1007 PS4, Line 1007: /oauth/token This endpoint needs to be configurable. http://gerrit.cloudera.org:8080/#/c/22424/4/shell/impala_shell.py@1008 PS4, Line 1008: res = conn.getresponse() Need to check the response code for errors and handle them as much as possible. -- To view, visit http://gerrit.cloudera.org:8080/22424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84e26d54f6a53696660728efb239ffd43de4c55d Gerrit-Change-Number: 22424 Gerrit-PatchSet: 4 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Comment-Date: Fri, 28 Feb 2025 23:44:22 +0000 Gerrit-HasComments: Yes
