Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22424 )
Change subject: IMPALA-13675: OAuth AuthN Support for Impala Shell ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/22424/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22424/8//COMMIT_MSG@9 PS8, Line 9: This patch adds the support to fetch access tokens Please also explain which OAuth flow is being implemented. http://gerrit.cloudera.org:8080/#/c/22424/8//COMMIT_MSG@15 PS8, Line 15: Testing(okta oauth server): > Since the request/response are dependent on okta implementation, they can c Tests can still assert the proper payload was passed to the mock auth server and the response payload was also properly parsed. Ideally, the test flow would: 1. Sent client id/secret to mock auth server which with assert the received payload. 2. The mock server generates a new JWT and returns it in the response payload. 3. The Impala shell uses the received JWT to successfully authenticate with Impala. The test asserts the connection was successful and a query could be executed. Note: check out test_shell_jwt_auth.py for an example of how to use the pre-existing JWKSs/JWTs for this test. http://gerrit.cloudera.org:8080/#/c/22424/8/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22424/8/shell/impala_shell.py@1017 PS8, Line 1017: print("HTTP error: ", res.status, res.read().decode("utf-8")) > Done Done http://gerrit.cloudera.org:8080/#/c/22424/8/shell/impala_shell.py@1021 PS8, Line 1021: self.oauth = json_body["access_token"] > There is a separate jira for that. Will be implemented as a separate patch. Done -- To view, visit http://gerrit.cloudera.org:8080/22424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84e26d54f6a53696660728efb239ffd43de4c55d Gerrit-Change-Number: 22424 Gerrit-PatchSet: 9 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Wed, 19 Mar 2025 20:41:27 +0000 Gerrit-HasComments: Yes
