gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/22424 )
Change subject: IMPALA-13675: OAuth AuthN Support for Impala Shell ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/22424/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22424/4//COMMIT_MSG@13 PS4, Line 13: be prompted to ent > Nit: or the user can be prompted to enter Done http://gerrit.cloudera.org:8080/#/c/22424/4//COMMIT_MSG@15 PS4, Line 15: Testing: > Need explanation of what testing was performed. Done http://gerrit.cloudera.org:8080/#/c/22424/4/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22424/4/shell/impala_shell.py@1002 PS4, Line 1002: print("Error: OAuth endpoint is empty") > Does this connection use UTF-8 encoding by default (since UTF-8 is a requir Added payload.encode('utf-8'). Thanks. http://gerrit.cloudera.org:8080/#/c/22424/4/shell/impala_shell.py@1003 PS4, Line 1003: sys.exit(1) > Does this payload also need a "scope" parameter as per https://datatracker. No, since we are giving all access to the user. There is no scope associated with authorization. http://gerrit.cloudera.org:8080/#/c/22424/4/shell/impala_shell.py@1007 PS4, Line 1007: s first usin > This endpoint needs to be configurable. Added extra param: oauth_endpoint http://gerrit.cloudera.org:8080/#/c/22424/4/shell/impala_shell.py@1008 PS4, Line 1008: try: > Need to check the response code for errors and handle them as much as possi Added catch block for HTTPException -- To view, visit http://gerrit.cloudera.org:8080/22424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84e26d54f6a53696660728efb239ffd43de4c55d Gerrit-Change-Number: 22424 Gerrit-PatchSet: 5 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Mar 2025 22:24:46 +0000 Gerrit-HasComments: Yes
