Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22413 )
Change subject: IMPALA-13717: Calcite Planner, enable UTF-8 character set ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22413/5/java/calcite-planner/src/main/codegen/templates/Parser.jj File java/calcite-planner/src/main/codegen/templates/Parser.jj: http://gerrit.cloudera.org:8080/#/c/22413/5/java/calcite-planner/src/main/codegen/templates/Parser.jj@4480 PS5, Line 4480: String charSet = "UTF8"; > e.g. https://github.com/apache/drill/blob/master/exec/java-exec/src/test/re Ooh! Thanks for the tip! I just looked up the interface in Calcite. Apparently that's been deprecated: https://calcite.apache.org/javadocAggregate/org/apache/calcite/util/SaffronProperties.html But it does point to CalciteSystemProperty which does have a DEFAULT_CHARSET property. I'll experiment with that and see how it goes. -- To view, visit http://gerrit.cloudera.org:8080/22413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f4a01a28aa673fbd9239177accaec182f0972b0 Gerrit-Change-Number: 22413 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2025 14:11:42 +0000 Gerrit-HasComments: Yes
