Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22413 )
Change subject: IMPALA-13717: Calcite Planner, enable UTF-8 character set ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22413/5/java/calcite-planner/src/main/codegen/templates/Parser.jj File java/calcite-planner/src/main/codegen/templates/Parser.jj: http://gerrit.cloudera.org:8080/#/c/22413/5/java/calcite-planner/src/main/codegen/templates/Parser.jj@4480 PS5, Line 4480: String charSet = "UTF8"; > do we need add saffron.properties file in java/calcite-planner/src/main/res Not sure what that is. Can you explain or provide a resource? If it makes sense to add it, maybe we should file a Jira for it and place it in another patch? -- To view, visit http://gerrit.cloudera.org:8080/22413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f4a01a28aa673fbd9239177accaec182f0972b0 Gerrit-Change-Number: 22413 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2025 03:05:05 +0000 Gerrit-HasComments: Yes
