Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22413 )
Change subject: IMPALA-13717: Calcite Planner, enable UTF-8 character set ...................................................................... Patch Set 3: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22413/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java: http://gerrit.cloudera.org:8080/#/c/22413/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@90 PS3, Line 90: RelDataType stringType = factory.createSqlType(SqlTypeName.VARCHAR, Integer.MAX_VALUE); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f4a01a28aa673fbd9239177accaec182f0972b0 Gerrit-Change-Number: 22413 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 04 Feb 2025 15:02:56 +0000 Gerrit-HasComments: Yes
