Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 35: (2 comments) http://gerrit.cloudera.org:8080/#/c/20447/35/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/35/be/src/exprs/string-functions-ir.cc@1943 PS35, Line 1943: Nit: unnecessary newline. http://gerrit.cloudera.org:8080/#/c/20447/35/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/20447/35/be/src/exprs/string-functions.cc@547 PS35, Line 547: // If a particular mode passed by user is not supported then an error is thrown. Instead of this comment, I think we could just refer to the decryption function comment. Something like this: "An entrypoint to perform AES encryption on a given expression string. In contrast to AesDecryptImpl(), does not support ECB modes. For other details, see the comment at AesDecryptImpl()." -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 35 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Sun, 26 Jan 2025 17:11:42 +0000 Gerrit-HasComments: Yes
