Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 32: (12 comments) > Uploaded patch set 32. http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/exprs/string-functions-ir.cc@22 PS31, Line 22: #include <stdint.h> > We no longer need the added includes on L22, 23, 25, 34, 38 and 41. Done http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/exprs/string-functions.h File be/src/exprs/string-functions.h: http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/exprs/string-functions.h@112 PS31, Line 112: s > Nit: unneeded space. Done http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/exprs/string-functions.cc@38 PS31, Line 38: > This import is not needed. Done http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/exprs/string-functions.cc@433 PS31, Line 433: } > Here '*state' is already true. This should be in the IF block, but only whe Done http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/runtime/tmp-file-mgr.cc@2080 PS31, Line 2080: RETURN_IF_ERROR(key_.InitializeRandom(32, AES_BLOCK_SIZE, > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/util/openssl-util-test.cc File be/src/util/openssl-util-test.cc: http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/util/openssl-util-test.cc@153 PS31, Line 153: /// Test to check whether key and mode are validated in InitializeRandom() > line too long (98 > 90) Done http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/util/openssl-util-test.cc@156 PS31, Line 156: EncryptionKey key; > line too long (106 > 90) Done http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/util/openssl-util-test.cc@159 PS31, Line 159: ASSERT_FALSE(status_initialze_random.ok()); > line too long (109 > 90) Done http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/util/openssl-util-test.cc@160 PS31, Line 160: ASSERT_OK(key.InitializeRandom(32, AES_BLOCK_SIZE, AES_CIPHER_MODE::AES_256_GCM)); > line too long (105 > 90) Done http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/util/openssl-util-test.cc@160 PS31, Line 160: CK_SIZE, AE > This is not AES_BLOCK_SIZE long, there will be a buffer overflow. Also on L Done http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/util/openssl-util-test.cc@163 PS31, Line 163: 16, reinterpret_cast<const uint8_t*>("12345678901234567890123456789012"), > line too long (106 > 90) Done http://gerrit.cloudera.org:8080/#/c/20447/31/testdata/workloads/functional-query/queries/QueryTest/encryption_exprs.test File testdata/workloads/functional-query/queries/QueryTest/encryption_exprs.test: http://gerrit.cloudera.org:8080/#/c/20447/31/testdata/workloads/functional-query/queries/QueryTest/encryption_exprs.test@448 PS31, Line 448: : : : > Nit: unneeded empty lines. Done -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 32 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Sat, 25 Jan 2025 04:14:33 +0000 Gerrit-HasComments: Yes
