Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 36: (2 comments) http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/20447/36/be/src/util/openssl-util.cc@334 PS36, Line 334: success = encrypt ? EVP_EncryptFinal_ex(ctx.ctx, out + output_offset, : &final_out_len) : EVP_DecryptFinal_ex(ctx.ctx, out : + output_offset, &final_out_len); nit: Unnecessary line breaks makes the code less legible. Please break line after ':'. http://gerrit.cloudera.org:8080/#/c/20447/36/testdata/workloads/functional-query/queries/QueryTest/encryption_exprs.test File testdata/workloads/functional-query/queries/QueryTest/encryption_exprs.test: http://gerrit.cloudera.org:8080/#/c/20447/36/testdata/workloads/functional-query/queries/QueryTest/encryption_exprs.test@67 PS36, Line 67: aes_decrypt(aes_encrypt( Please cover the other way around, meaning decrypting first then encrypting. -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 36 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Mon, 27 Jan 2025 10:55:40 +0000 Gerrit-HasComments: Yes
