Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 31: (6 comments) http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/runtime/tmp-file-mgr.cc@2080 PS31, Line 2080: RETURN_IF_ERROR(key_.InitializeRandom(32, AES_BLOCK_SIZE, key_.GetSupportedDefaultMode())); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/util/openssl-util-test.cc File be/src/util/openssl-util-test.cc: http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/util/openssl-util-test.cc@153 PS31, Line 153: /// Test to check whether key and mode are validated in InitializeRandom() and InitializeFields(). line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/util/openssl-util-test.cc@156 PS31, Line 156: Status status_initialze_random = key.InitializeRandom(32, AES_BLOCK_SIZE, AES_CIPHER_MODE::AES_128_GCM); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/util/openssl-util-test.cc@159 PS31, Line 159: Status status_initialze_fields = key.InitializeFields(reinterpret_cast<const uint8_t*>("1234567890123456"), line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/util/openssl-util-test.cc@160 PS31, Line 160: 16, reinterpret_cast<const uint8_t*>("12345678901"), AES_BLOCK_SIZE, AES_CIPHER_MODE::AES_256_GCM); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/20447/31/be/src/util/openssl-util-test.cc@163 PS31, Line 163: 16, reinterpret_cast<const uint8_t*>("12345678901"), AES_BLOCK_SIZE, AES_CIPHER_MODE::AES_128_GCM)); line too long (106 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 31 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Fri, 24 Jan 2025 17:48:52 +0000 Gerrit-HasComments: Yes
