Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 29: (3 comments) Nice patch! After resolving Daniel's comments, too, I think it will be good to go. http://gerrit.cloudera.org:8080/#/c/20447/29/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/20447/29/be/src/util/openssl-util.cc@228 PS29, Line 228: Input buffer length exceeds the supported length" : " for ECB mode."); nit: Can this fit in one line? http://gerrit.cloudera.org:8080/#/c/20447/29/be/src/util/openssl-util.cc@264 PS29, Line 264: if (EVP_CIPHER_CTX_ctrl(ctx.ctx, EVP_CTRL_GCM_SET_IVLEN, iv_length_, nullptr) : != 1) { nit: Can this fit in one line? http://gerrit.cloudera.org:8080/#/c/20447/29/testdata/workloads/functional-query/queries/QueryTest/exprs.test File testdata/workloads/functional-query/queries/QueryTest/exprs.test: http://gerrit.cloudera.org:8080/#/c/20447/29/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3355 PS29, Line 3355: select aes_decrypt(aes_encrypt('ABC', '12345678901234567890123456789012','AES_256_GCM','1234567890123456'), : '12345678901234567890123456789012','AES_256_GCM','1234567890123456'); Do you think it could make sense to add test cases for the other way around: decrypting first then encrypting? -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 29 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Tue, 14 Jan 2025 13:07:00 +0000 Gerrit-HasComments: Yes
